Commit 2af588d5 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

USB: quatech_usb2.c: remove dbg() tracing calls

dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
CC: Kautuk Consul <consul.kautuk@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7275fc4c
...@@ -415,8 +415,6 @@ static void qt2_release(struct usb_serial *serial) ...@@ -415,8 +415,6 @@ static void qt2_release(struct usb_serial *serial)
struct quatech2_port *qt_port; struct quatech2_port *qt_port;
int i; int i;
dbg("enterting %s", __func__);
for (i = 0; i < serial->num_ports; i++) { for (i = 0; i < serial->num_ports; i++) {
port = serial->port[i]; port = serial->port[i];
if (!port) if (!port)
...@@ -455,8 +453,6 @@ int qt2_open(struct tty_struct *tty, struct usb_serial_port *port) ...@@ -455,8 +453,6 @@ int qt2_open(struct tty_struct *tty, struct usb_serial_port *port)
if (port_paranoia_check(port, __func__)) if (port_paranoia_check(port, __func__))
return -ENODEV; return -ENODEV;
dbg("%s(): port %d", __func__, port->number);
serial = port->serial; /* get the parent device structure */ serial = port->serial; /* get the parent device structure */
if (serial_paranoia_check(serial, __func__)) { if (serial_paranoia_check(serial, __func__)) {
dbg("usb_serial struct failed sanity check"); dbg("usb_serial struct failed sanity check");
...@@ -636,7 +632,6 @@ static void qt2_close(struct usb_serial_port *port) ...@@ -636,7 +632,6 @@ static void qt2_close(struct usb_serial_port *port)
__u8 lsr_value = 0; /* value of Line Status Register */ __u8 lsr_value = 0; /* value of Line Status Register */
int status; /* result of last USB comms function */ int status; /* result of last USB comms function */
dbg("%s(): port %d", __func__, port->number);
serial = port->serial; /* get the parent device structure */ serial = port->serial; /* get the parent device structure */
dev_extra = qt2_get_dev_private(serial); dev_extra = qt2_get_dev_private(serial);
/* get the device private data */ /* get the device private data */
...@@ -971,10 +966,7 @@ static void qt2_set_termios(struct tty_struct *tty, ...@@ -971,10 +966,7 @@ static void qt2_set_termios(struct tty_struct *tty,
int status; int status;
__u16 UartNumber; __u16 UartNumber;
dbg("%s(): port %d", __func__, port->number);
serial = port->serial; serial = port->serial;
UartNumber = port->number; UartNumber = port->number;
if (old_termios && !tty_termios_hw_change(old_termios, tty->termios)) if (old_termios && !tty_termios_hw_change(old_termios, tty->termios))
...@@ -1096,9 +1088,7 @@ static int qt2_tiocmget(struct tty_struct *tty) ...@@ -1096,9 +1088,7 @@ static int qt2_tiocmget(struct tty_struct *tty)
if (serial == NULL) if (serial == NULL)
return -ENODEV; return -ENODEV;
dbg("%s(): port %d, tty =0x%p", __func__, port->number, tty);
UartNumber = tty->index - serial->minor; UartNumber = tty->index - serial->minor;
dbg("UartNumber is %d", UartNumber);
status = qt2_box_get_register(port->serial, UartNumber, status = qt2_box_get_register(port->serial, UartNumber,
QT2_MODEM_CONTROL_REGISTER, &mcr_value); QT2_MODEM_CONTROL_REGISTER, &mcr_value);
...@@ -1138,7 +1128,6 @@ static int qt2_tiocmset(struct tty_struct *tty, ...@@ -1138,7 +1128,6 @@ static int qt2_tiocmset(struct tty_struct *tty,
return -ENODEV; return -ENODEV;
UartNumber = tty->index - serial->minor; UartNumber = tty->index - serial->minor;
dbg("%s(): port %d, UartNumber %d", __func__, port->number, UartNumber);
status = qt2_box_get_register(port->serial, UartNumber, status = qt2_box_get_register(port->serial, UartNumber,
QT2_MODEM_CONTROL_REGISTER, &mcr_value); QT2_MODEM_CONTROL_REGISTER, &mcr_value);
...@@ -1198,7 +1187,6 @@ static void qt2_break(struct tty_struct *tty, int break_state) ...@@ -1198,7 +1187,6 @@ static void qt2_break(struct tty_struct *tty, int break_state)
port->number, NULL, 0, 300); port->number, NULL, 0, 300);
exit: exit:
mutex_unlock(&port_extra->modelock); mutex_unlock(&port_extra->modelock);
dbg("%s(): exit port %d", __func__, port->number);
} }
/** /**
...@@ -1209,7 +1197,6 @@ static void qt2_throttle(struct tty_struct *tty) ...@@ -1209,7 +1197,6 @@ static void qt2_throttle(struct tty_struct *tty)
struct usb_serial_port *port = tty->driver_data; struct usb_serial_port *port = tty->driver_data;
struct usb_serial *serial = port->serial; struct usb_serial *serial = port->serial;
struct quatech2_port *port_extra; /* extra data for this port */ struct quatech2_port *port_extra; /* extra data for this port */
dbg("%s(): port %d", __func__, port->number);
port_extra = qt2_get_port_private(port); port_extra = qt2_get_port_private(port);
if (!serial) { if (!serial) {
...@@ -1255,7 +1242,6 @@ static void qt2_unthrottle(struct tty_struct *tty) ...@@ -1255,7 +1242,6 @@ static void qt2_unthrottle(struct tty_struct *tty)
port->number); port->number);
return; return;
} }
dbg("%s(): enter port %d", __func__, port->number);
dev_extra = qt2_get_dev_private(serial); dev_extra = qt2_get_dev_private(serial);
port_extra = qt2_get_port_private(port); port_extra = qt2_get_port_private(port);
port0 = serial->port[0]; /* get the first port's device structure */ port0 = serial->port[0]; /* get the first port's device structure */
...@@ -1285,7 +1271,6 @@ static void qt2_unthrottle(struct tty_struct *tty) ...@@ -1285,7 +1271,6 @@ static void qt2_unthrottle(struct tty_struct *tty)
} }
exit: exit:
mutex_unlock(&port_extra->modelock); mutex_unlock(&port_extra->modelock);
dbg("%s(): exit port %d", __func__, port->number);
return; return;
} }
...@@ -1682,7 +1667,6 @@ __func__); ...@@ -1682,7 +1667,6 @@ __func__);
/* cribbed from serqt_usb2 driver, but not sure which work needs /* cribbed from serqt_usb2 driver, but not sure which work needs
* scheduling - port0 or currently active port? */ * scheduling - port0 or currently active port? */
/* schedule_work(&port->work); */ /* schedule_work(&port->work); */
dbg("%s() completed", __func__);
return; return;
} }
...@@ -1696,7 +1680,7 @@ static void qt2_write_bulk_callback(struct urb *urb) ...@@ -1696,7 +1680,7 @@ static void qt2_write_bulk_callback(struct urb *urb)
{ {
struct usb_serial_port *port = (struct usb_serial_port *)urb->context; struct usb_serial_port *port = (struct usb_serial_port *)urb->context;
struct usb_serial *serial = port->serial; struct usb_serial *serial = port->serial;
dbg("%s(): port %d", __func__, port->number);
if (!serial) { if (!serial) {
dbg("%s(): bad serial pointer, exiting", __func__); dbg("%s(): bad serial pointer, exiting", __func__);
return; return;
...@@ -1711,7 +1695,6 @@ static void qt2_write_bulk_callback(struct urb *urb) ...@@ -1711,7 +1695,6 @@ static void qt2_write_bulk_callback(struct urb *urb)
*/ */
/*port_softint((void *) serial); commented in vendor driver */ /*port_softint((void *) serial); commented in vendor driver */
schedule_work(&port->work); schedule_work(&port->work);
dbg("%s(): port %d exit", __func__, port->number);
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment