Commit 2b7db29b authored by From: Gustavo A. R. Silva's avatar From: Gustavo A. R. Silva Committed by Mauro Carvalho Chehab

media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe.
The proper pointer to be passed as argument is pinctrl
instead of priv->vdev.

This issue was detected with the help of Coccinelle.

Fixes: 52e17089 ("media: imx: Don't initialize vars that won't be used")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarFabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Tested-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 6da6c0db
...@@ -1799,7 +1799,7 @@ static int imx_csi_probe(struct platform_device *pdev) ...@@ -1799,7 +1799,7 @@ static int imx_csi_probe(struct platform_device *pdev)
priv->dev->of_node = pdata->of_node; priv->dev->of_node = pdata->of_node;
pinctrl = devm_pinctrl_get_select_default(priv->dev); pinctrl = devm_pinctrl_get_select_default(priv->dev);
if (IS_ERR(pinctrl)) { if (IS_ERR(pinctrl)) {
ret = PTR_ERR(priv->vdev); ret = PTR_ERR(pinctrl);
dev_dbg(priv->dev, dev_dbg(priv->dev,
"devm_pinctrl_get_select_default() failed: %d\n", ret); "devm_pinctrl_get_select_default() failed: %d\n", ret);
if (ret != -ENODEV) if (ret != -ENODEV)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment