Commit 2bab693a authored by Marc Zyngier's avatar Marc Zyngier Committed by Ard Biesheuvel

firmware/efi: Tell memblock about EFI iomem reservations

kexec_load_file() relies on the memblock infrastructure to avoid
stamping over regions of memory that are essential to the survival
of the system.

However, nobody seems to agree how to flag these regions as reserved,
and (for example) EFI only publishes its reservations in /proc/iomem
for the benefit of the traditional, userspace based kexec tool.

On arm64 platforms with GICv3, this can result in the payload being
placed at the location of the LPI tables. Shock, horror!

Let's augment the EFI reservation code with a memblock_reserve() call,
protecting our dear tables from the secondary kernel invasion.
Reported-by: default avatarMoritz Fischer <mdf@kernel.org>
Tested-by: default avatarMoritz Fischer <mdf@kernel.org>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: James Morse <james.morse@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent 674a9f1f
...@@ -896,6 +896,7 @@ static int __init efi_memreserve_map_root(void) ...@@ -896,6 +896,7 @@ static int __init efi_memreserve_map_root(void)
static int efi_mem_reserve_iomem(phys_addr_t addr, u64 size) static int efi_mem_reserve_iomem(phys_addr_t addr, u64 size)
{ {
struct resource *res, *parent; struct resource *res, *parent;
int ret;
res = kzalloc(sizeof(struct resource), GFP_ATOMIC); res = kzalloc(sizeof(struct resource), GFP_ATOMIC);
if (!res) if (!res)
...@@ -908,7 +909,17 @@ static int efi_mem_reserve_iomem(phys_addr_t addr, u64 size) ...@@ -908,7 +909,17 @@ static int efi_mem_reserve_iomem(phys_addr_t addr, u64 size)
/* we expect a conflict with a 'System RAM' region */ /* we expect a conflict with a 'System RAM' region */
parent = request_resource_conflict(&iomem_resource, res); parent = request_resource_conflict(&iomem_resource, res);
return parent ? request_resource(parent, res) : 0; ret = parent ? request_resource(parent, res) : 0;
/*
* Given that efi_mem_reserve_iomem() can be called at any
* time, only call memblock_reserve() if the architecture
* keeps the infrastructure around.
*/
if (IS_ENABLED(CONFIG_ARCH_KEEP_MEMBLOCK) && !ret)
memblock_reserve(addr, size);
return ret;
} }
int __ref efi_mem_reserve_persistent(phys_addr_t addr, u64 size) int __ref efi_mem_reserve_persistent(phys_addr_t addr, u64 size)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment