Commit 2bbba115 authored by Randy Dunlap's avatar Randy Dunlap Committed by Mark Brown

regulator: tps65219: use IS_ERR() to detect an error pointer

Fix pointer comparison to integer warning from gcc & sparse:

GCC:
../drivers/regulator/tps65219-regulator.c:370:26: warning: ordered comparison of pointer with integer zero [-Wextra]
  370 |                 if (rdev < 0) {
      |                          ^

sparse warning:
drivers/regulator/tps65219-regulator.c:370:26: sparse: error: incompatible types for operation (<):
drivers/regulator/tps65219-regulator.c:370:26: sparse:    struct regulator_dev *[assigned] rdev
drivers/regulator/tps65219-regulator.c:370:26: sparse:    int

Fixes: c12ac5fc ("regulator: drivers: Add TI TPS65219 PMIC regulators support")
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Jerome Neanne <jneanne@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230114185736.2076-1-rdunlap@infradead.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 84c13763
...@@ -367,7 +367,7 @@ static int tps65219_regulator_probe(struct platform_device *pdev) ...@@ -367,7 +367,7 @@ static int tps65219_regulator_probe(struct platform_device *pdev)
irq_data[i].type = irq_type; irq_data[i].type = irq_type;
tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, rdev); tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, rdev);
if (rdev < 0) { if (IS_ERR(rdev)) {
dev_err(tps->dev, "Failed to get rdev for %s\n", dev_err(tps->dev, "Failed to get rdev for %s\n",
irq_type->regulator_name); irq_type->regulator_name);
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment