Commit 2bef64b8 authored by Roger Quadros's avatar Roger Quadros Committed by Greg Kroah-Hartman

USB: ehci-omap: Improve PHY error handling

As the USB PHY layer never returns NULL we don't need
to check for that condition.
Signed-off-by: default avatarRoger Quadros <rogerq@ti.com>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7c4ebe68
...@@ -175,12 +175,12 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) ...@@ -175,12 +175,12 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
phy = devm_usb_get_phy_by_phandle(dev, "phys", i); phy = devm_usb_get_phy_by_phandle(dev, "phys", i);
else else
phy = devm_usb_get_phy_dev(dev, i); phy = devm_usb_get_phy_dev(dev, i);
if (IS_ERR(phy) || !phy) { if (IS_ERR(phy)) {
/* Don't bail out if PHY is not absolutely necessary */ /* Don't bail out if PHY is not absolutely necessary */
if (pdata->port_mode[i] != OMAP_EHCI_PORT_MODE_PHY) if (pdata->port_mode[i] != OMAP_EHCI_PORT_MODE_PHY)
continue; continue;
ret = IS_ERR(phy) ? PTR_ERR(phy) : -ENODEV; ret = PTR_ERR(phy);
dev_err(dev, "Can't get PHY device for port %d: %d\n", dev_err(dev, "Can't get PHY device for port %d: %d\n",
i, ret); i, ret);
goto err_phy; goto err_phy;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment