Commit 2c4283ca authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

staging: comedi: dt282x: dt282x_ai_insn_read() always fails

In dt282x_ai_insn_read() we call this macro like:
wait_for(!mux_busy(), comedi_error(dev, "timeout\n"); return -ETIME;);
Because the if statement doesn't have curly braces it means we always
return -ETIME and the function never succeeds.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarIan Abbott <abbotti@mev.co.uk>
Cc: stable <stable@vger.kernel.org> # 2.6.36+
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ded82ef9
...@@ -267,8 +267,9 @@ struct dt282x_private { ...@@ -267,8 +267,9 @@ struct dt282x_private {
} \ } \
udelay(5); \ udelay(5); \
} \ } \
if (_i) \ if (_i) { \
b \ b \
} \
} while (0) } while (0)
static int prep_ai_dma(struct comedi_device *dev, int chan, int size); static int prep_ai_dma(struct comedi_device *dev, int chan, int size);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment