Commit 2c84599c authored by Sheng Yong's avatar Sheng Yong Committed by Artem Bityutskiy

UBIFS: do not write master node if need recovery

The commits 781c5717 ("UBIFS: intialize LPT earlier") and 09801194 ("UBIFS:
fix-up free space earlier") move some initialization before marking the
master node dirty. But the modification changes the conditions of writing
master.

If unclean umount happens, ubifs may fail when mounting. But trying to
mount it will write new master nodes on the flash. This is useless but
increasing sqnum. So check need_recovery before writing master node, and
don't create new master node if filesystem needs recovery.

The behavour of the bug shows at:
http://lists.infradead.org/pipermail/linux-mtd/2015-February/057712.htmlSigned-off-by: default avatarSheng Yong <shengyong1@huawei.com>
Reviewed-by: default avatarBen Gardiner <ben.l.gardiner@gmail.com>
Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
parent 9401a795
......@@ -1284,7 +1284,7 @@ static int mount_ubifs(struct ubifs_info *c)
goto out_lpt;
}
if (!c->ro_mount) {
if (!c->ro_mount && !c->need_recovery) {
/*
* Set the "dirty" flag so that if we reboot uncleanly we
* will notice this immediately on the next mount.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment