Commit 2c8e3f44 authored by Rui Miguel Silva's avatar Rui Miguel Silva Committed by Greg Kroah-Hartman

staging: typec: fusb302: do not free gpio from managed resource

When allocating a gpio using the managed resource devm_, we can avoid freeing it
manually. But even if we did it we should use devm_gpio_free.

So, just remove the free of the gpio in the error path.
Signed-off-by: default avatarRui Miguel Silva <rmfrfs@gmail.com>
Acked-by: default avatarYueyao Zhu <yueyao.zhu@gmail.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 050161ea
...@@ -1663,14 +1663,12 @@ static int init_gpio(struct fusb302_chip *chip) ...@@ -1663,14 +1663,12 @@ static int init_gpio(struct fusb302_chip *chip)
if (ret < 0) { if (ret < 0) {
fusb302_log(chip, fusb302_log(chip,
"cannot set GPIO Int_N to input, ret=%d", ret); "cannot set GPIO Int_N to input, ret=%d", ret);
gpio_free(chip->gpio_int_n);
return ret; return ret;
} }
ret = gpio_to_irq(chip->gpio_int_n); ret = gpio_to_irq(chip->gpio_int_n);
if (ret < 0) { if (ret < 0) {
fusb302_log(chip, fusb302_log(chip,
"cannot request IRQ for GPIO Int_N, ret=%d", ret); "cannot request IRQ for GPIO Int_N, ret=%d", ret);
gpio_free(chip->gpio_int_n);
return ret; return ret;
} }
chip->gpio_int_n_irq = ret; chip->gpio_int_n_irq = ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment