Commit 2c92488a authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds

checkpatch: warn on use of yield()

Using yield() is generally wrong.  Warn on its use.
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent aad4f614
...@@ -3338,6 +3338,12 @@ sub process { ...@@ -3338,6 +3338,12 @@ sub process {
"__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); "__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
} }
# check for use of yield()
if ($line =~ /\byield\s*\(\s*\)/) {
WARN("YIELD",
"Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)\n" . $herecurr);
}
# check for semaphores initialized locked # check for semaphores initialized locked
if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) { if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
WARN("CONSIDER_COMPLETION", WARN("CONSIDER_COMPLETION",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment