Commit 2c98b8a3 authored by Pavel Skripkin's avatar Pavel Skripkin Committed by Mauro Carvalho Chehab

media: em28xx: add missing em28xx_close_extension

If em28xx dev has ->dev_next pointer, we need to delete ->dev_next list
node from em28xx_extension_devlist on disconnect to avoid UAF bugs and
corrupted list bugs, since driver frees this pointer on disconnect.

Reported-and-tested-by: syzbot+a6969ef522a36d3344c9@syzkaller.appspotmail.com

Fixes: 1a23f81b ("V4L/DVB (9979): em28xx: move usb probe code to a proper place")
Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 9015fcc2
...@@ -4139,8 +4139,11 @@ static void em28xx_usb_disconnect(struct usb_interface *intf) ...@@ -4139,8 +4139,11 @@ static void em28xx_usb_disconnect(struct usb_interface *intf)
em28xx_close_extension(dev); em28xx_close_extension(dev);
if (dev->dev_next) if (dev->dev_next) {
em28xx_close_extension(dev->dev_next);
em28xx_release_resources(dev->dev_next); em28xx_release_resources(dev->dev_next);
}
em28xx_release_resources(dev); em28xx_release_resources(dev);
if (dev->dev_next) { if (dev->dev_next) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment