Commit 2cd65577 authored by Arun Chandran's avatar Arun Chandran Committed by Zefan Li

regmap: Fix regmap_bulk_read in BE mode

commit 15b8d2c4 upstream.

In big endian mode regmap_bulk_read gives incorrect data
for byte reads.

This is because memcpy of a single byte from an address
after full word read gives different results when
endianness differs. ie. we get little-end in LE and big-end in BE.
Signed-off-by: default avatarArun Chandran <achandran@mvista.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
[lizf: Backported to 3.4: format_val() takes only two arguments]
Signed-off-by: default avatarZefan Li <lizefan@huawei.com>
parent ddae448f
...@@ -784,7 +784,7 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val, ...@@ -784,7 +784,7 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val,
ret = regmap_read(map, reg + i, &ival); ret = regmap_read(map, reg + i, &ival);
if (ret != 0) if (ret != 0)
return ret; return ret;
memcpy(val + (i * val_bytes), &ival, val_bytes); map->format.format_val(val + (i * val_bytes), ival);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment