Commit 2d7f9e2a authored by Seth Forshee's avatar Seth Forshee Committed by Eric W. Biederman

fs: Check for invalid i_uid in may_follow_link()

Filesystem uids which don't map into a user namespace may result
in inode->i_uid being INVALID_UID. A symlink and its parent
could have different owners in the filesystem can both get
mapped to INVALID_UID, which may result in following a symlink
when this would not have otherwise been permitted when protected
symlinks are enabled.
Signed-off-by: default avatarSeth Forshee <seth.forshee@canonical.com>
Acked-by: default avatarSerge Hallyn <serge.hallyn@canonical.com>
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
parent 0d4d717f
...@@ -901,6 +901,7 @@ static inline int may_follow_link(struct nameidata *nd) ...@@ -901,6 +901,7 @@ static inline int may_follow_link(struct nameidata *nd)
{ {
const struct inode *inode; const struct inode *inode;
const struct inode *parent; const struct inode *parent;
kuid_t puid;
if (!sysctl_protected_symlinks) if (!sysctl_protected_symlinks)
return 0; return 0;
...@@ -916,7 +917,8 @@ static inline int may_follow_link(struct nameidata *nd) ...@@ -916,7 +917,8 @@ static inline int may_follow_link(struct nameidata *nd)
return 0; return 0;
/* Allowed if parent directory and link owner match. */ /* Allowed if parent directory and link owner match. */
if (uid_eq(parent->i_uid, inode->i_uid)) puid = parent->i_uid;
if (uid_valid(puid) && uid_eq(puid, inode->i_uid))
return 0; return 0;
if (nd->flags & LOOKUP_RCU) if (nd->flags & LOOKUP_RCU)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment