Commit 2da57fa0 authored by Wen Yang's avatar Wen Yang Committed by Greg Kroah-Hartman

pinctrl: pistachio: fix leaked of_node references

[ Upstream commit 44a4455a ]

The call to of_get_child_by_name returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./drivers/pinctrl/pinctrl-pistachio.c:1422:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1360, but without a corresponding object release within this function.
Signed-off-by: default avatarWen Yang <wen.yang99@zte.com.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e2cde780
...@@ -1368,6 +1368,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) ...@@ -1368,6 +1368,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
if (!of_find_property(child, "gpio-controller", NULL)) { if (!of_find_property(child, "gpio-controller", NULL)) {
dev_err(pctl->dev, dev_err(pctl->dev,
"No gpio-controller property for bank %u\n", i); "No gpio-controller property for bank %u\n", i);
of_node_put(child);
ret = -ENODEV; ret = -ENODEV;
goto err; goto err;
} }
...@@ -1375,6 +1376,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) ...@@ -1375,6 +1376,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
irq = irq_of_parse_and_map(child, 0); irq = irq_of_parse_and_map(child, 0);
if (irq < 0) { if (irq < 0) {
dev_err(pctl->dev, "No IRQ for bank %u: %d\n", i, irq); dev_err(pctl->dev, "No IRQ for bank %u: %d\n", i, irq);
of_node_put(child);
ret = irq; ret = irq;
goto err; goto err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment