Commit 2dc803d0 authored by Vladis Dronov's avatar Vladis Dronov Committed by Greg Kroah-Hartman

USB: serial: visor: fix crash on detecting device without write_urbs

commit cb323213 upstream.

The visor driver crashes in clie_5_attach() when a specially crafted USB
device without bulk-out endpoint is detected. This fix adds a check that
the device has proper configuration expected by the driver.
Reported-by: default avatarRalf Spenneberg <ralf@spenneberg.net>
Signed-off-by: default avatarVladis Dronov <vdronov@redhat.com>
Fixes: cfb8da8f ("USB: visor: fix initialisation of UX50/TH55 devices")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2bbe5162
...@@ -597,8 +597,10 @@ static int clie_5_attach(struct usb_serial *serial) ...@@ -597,8 +597,10 @@ static int clie_5_attach(struct usb_serial *serial)
*/ */
/* some sanity check */ /* some sanity check */
if (serial->num_ports < 2) if (serial->num_bulk_out < 2) {
return -1; dev_err(&serial->interface->dev, "missing bulk out endpoints\n");
return -ENODEV;
}
/* port 0 now uses the modified endpoint Address */ /* port 0 now uses the modified endpoint Address */
port = serial->port[0]; port = serial->port[0];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment