Commit 2e42a7dc authored by Axel Lin's avatar Axel Lin Committed by Mark Brown

regulator: max8998: Use simple equation to get selector

It's more efficient to get the best selector by simple equation.
Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 2358b776
...@@ -306,8 +306,7 @@ static int max8998_set_voltage_ldo(struct regulator_dev *rdev, ...@@ -306,8 +306,7 @@ static int max8998_set_voltage_ldo(struct regulator_dev *rdev,
int min_vol = min_uV / 1000, max_vol = max_uV / 1000; int min_vol = min_uV / 1000, max_vol = max_uV / 1000;
const struct voltage_map_desc *desc; const struct voltage_map_desc *desc;
int ldo = rdev_get_id(rdev); int ldo = rdev_get_id(rdev);
int reg, shift = 0, mask, ret; int reg, shift = 0, mask, ret, i;
int i = 0;
if (ldo >= ARRAY_SIZE(ldo_voltage_map)) if (ldo >= ARRAY_SIZE(ldo_voltage_map))
return -EINVAL; return -EINVAL;
...@@ -319,9 +318,10 @@ static int max8998_set_voltage_ldo(struct regulator_dev *rdev, ...@@ -319,9 +318,10 @@ static int max8998_set_voltage_ldo(struct regulator_dev *rdev,
if (max_vol < desc->min || min_vol > desc->max) if (max_vol < desc->min || min_vol > desc->max)
return -EINVAL; return -EINVAL;
while (desc->min + desc->step*i < min_vol && if (min_vol < desc->min)
desc->min + desc->step*i < desc->max) min_vol = desc->min;
i++;
i = DIV_ROUND_UP(min_vol - desc->min, desc->step);
if (desc->min + desc->step*i > max_vol) if (desc->min + desc->step*i > max_vol)
return -EINVAL; return -EINVAL;
...@@ -359,7 +359,7 @@ static int max8998_set_voltage_buck(struct regulator_dev *rdev, ...@@ -359,7 +359,7 @@ static int max8998_set_voltage_buck(struct regulator_dev *rdev,
const struct voltage_map_desc *desc; const struct voltage_map_desc *desc;
int buck = rdev_get_id(rdev); int buck = rdev_get_id(rdev);
int reg, shift = 0, mask, ret; int reg, shift = 0, mask, ret;
int difference = 0, i = 0, j = 0, previous_vol = 0; int difference = 0, i, j = 0, previous_vol = 0;
u8 val = 0; u8 val = 0;
static u8 buck1_last_val; static u8 buck1_last_val;
...@@ -374,9 +374,10 @@ static int max8998_set_voltage_buck(struct regulator_dev *rdev, ...@@ -374,9 +374,10 @@ static int max8998_set_voltage_buck(struct regulator_dev *rdev,
if (max_vol < desc->min || min_vol > desc->max) if (max_vol < desc->min || min_vol > desc->max)
return -EINVAL; return -EINVAL;
while (desc->min + desc->step*i < min_vol && if (min_vol < desc->min)
desc->min + desc->step*i < desc->max) min_vol = desc->min;
i++;
i = DIV_ROUND_UP(min_vol - desc->min, desc->step);
if (desc->min + desc->step*i > max_vol) if (desc->min + desc->step*i > max_vol)
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment