Commit 2e6424ab authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Linus Walleij

pinctrl: amd: fix error return code in amd_gpio_probe()

platform_get_irq() returns an error code, but the pinctrl-amd driver
ignores it and always returns -EINVAL. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent a96f50e6
...@@ -760,8 +760,8 @@ static int amd_gpio_probe(struct platform_device *pdev) ...@@ -760,8 +760,8 @@ static int amd_gpio_probe(struct platform_device *pdev)
irq_base = platform_get_irq(pdev, 0); irq_base = platform_get_irq(pdev, 0);
if (irq_base < 0) { if (irq_base < 0) {
dev_err(&pdev->dev, "Failed to get gpio IRQ.\n"); dev_err(&pdev->dev, "Failed to get gpio IRQ: %d\n", irq_base);
return -EINVAL; return irq_base;
} }
gpio_dev->pdev = pdev; gpio_dev->pdev = pdev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment