Commit 2f1c6c57 authored by Luis R. Rodriguez's avatar Luis R. Rodriguez Committed by Johannes Berg

cfg80211: process non country IE conflicting first

By dealing with non country IE conficts first we can shift
the code that deals with the conflict to the left. This has
no functional changes.
Signed-off-by: default avatarLuis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent b23e7a9e
...@@ -1539,31 +1539,32 @@ __reg_process_hint_country_ie(struct wiphy *wiphy, ...@@ -1539,31 +1539,32 @@ __reg_process_hint_country_ie(struct wiphy *wiphy,
return REG_REQ_ALREADY_SET; return REG_REQ_ALREADY_SET;
} }
last_wiphy = wiphy_idx_to_wiphy(lr->wiphy_idx);
if (unlikely(!is_an_alpha2(country_ie_request->alpha2))) if (unlikely(!is_an_alpha2(country_ie_request->alpha2)))
return -EINVAL; return -EINVAL;
if (lr->initiator == NL80211_REGDOM_SET_BY_COUNTRY_IE) {
if (last_wiphy != wiphy) { if (lr->initiator != NL80211_REGDOM_SET_BY_COUNTRY_IE)
/* return REG_REQ_OK;
* Two cards with two APs claiming different
* Country IE alpha2s. We could last_wiphy = wiphy_idx_to_wiphy(lr->wiphy_idx);
* intersect them, but that seems unlikely
* to be correct. Reject second one for now. if (last_wiphy != wiphy) {
*/
if (regdom_changes(country_ie_request->alpha2))
return REG_REQ_IGNORE;
return REG_REQ_ALREADY_SET;
}
/* /*
* Two consecutive Country IE hints on the same wiphy. * Two cards with two APs claiming different
* This should be picked up early by the driver/stack * Country IE alpha2s. We could
* intersect them, but that seems unlikely
* to be correct. Reject second one for now.
*/ */
if (WARN_ON(regdom_changes(country_ie_request->alpha2))) if (regdom_changes(country_ie_request->alpha2))
return REG_REQ_OK; return REG_REQ_IGNORE;
return REG_REQ_ALREADY_SET; return REG_REQ_ALREADY_SET;
} }
return REG_REQ_OK; /*
* Two consecutive Country IE hints on the same wiphy.
* This should be picked up early by the driver/stack
*/
if (WARN_ON(regdom_changes(country_ie_request->alpha2)))
return REG_REQ_OK;
return REG_REQ_ALREADY_SET;
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment