Commit 2f8a786f authored by Sun Ke's avatar Sun Ke Committed by Jakub Kicinski

net: dsa: microchip: lan937x: fix reference count leak in lan937x_mdio_register()

This node pointer is returned by of_find_compatible_node() with
refcount incremented in this function. of_node_put() on it before
exitting this function.

Fixes: c9cd961c ("net: dsa: microchip: lan937x: add interrupt support for port phy link")
Signed-off-by: default avatarSun Ke <sunke32@huawei.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220908040226.871690-1-sunke32@huawei.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 42666b2c
...@@ -238,8 +238,10 @@ static int lan937x_mdio_register(struct ksz_device *dev) ...@@ -238,8 +238,10 @@ static int lan937x_mdio_register(struct ksz_device *dev)
ds->slave_mii_bus = bus; ds->slave_mii_bus = bus;
ret = lan937x_irq_phy_setup(dev); ret = lan937x_irq_phy_setup(dev);
if (ret) if (ret) {
of_node_put(mdio_np);
return ret; return ret;
}
ret = devm_of_mdiobus_register(ds->dev, bus, mdio_np); ret = devm_of_mdiobus_register(ds->dev, bus, mdio_np);
if (ret) { if (ret) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment