Commit 2fa37fd7 authored by kbuild test robot's avatar kbuild test robot Committed by Mike Marshall

Orangefs: fix ifnullfree.cocci warnings

fs/orangefs/orangefs-debugfs.c:130:2-26: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci
Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarMike Marshall <hubcap@omnibond.com>
parent a9bb3ba8
...@@ -126,8 +126,7 @@ int orangefs_debugfs_init(void) ...@@ -126,8 +126,7 @@ int orangefs_debugfs_init(void)
void orangefs_debugfs_cleanup(void) void orangefs_debugfs_cleanup(void)
{ {
if (debug_dir) debugfs_remove_recursive(debug_dir);
debugfs_remove_recursive(debug_dir);
} }
/* open ORANGEFS_KMOD_DEBUG_HELP_FILE */ /* open ORANGEFS_KMOD_DEBUG_HELP_FILE */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment