Commit 2fe2d9f4 authored by Alexander Holler's avatar Alexander Holler Committed by Florian Tobias Schandinat

video/smscufx: fix line counting in fb_write

Line 0 and 1 were both written to line 0 (on the display) and all subsequent
lines had an offset of -1. The result was that the last line on the display
was never overwritten by writes to /dev/fbN.

The origin of this bug seems to have been udlfb.
Signed-off-by: default avatarAlexander Holler <holler@ahsoftware.de>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent 659f675e
...@@ -904,7 +904,7 @@ static ssize_t ufx_ops_write(struct fb_info *info, const char __user *buf, ...@@ -904,7 +904,7 @@ static ssize_t ufx_ops_write(struct fb_info *info, const char __user *buf,
result = fb_sys_write(info, buf, count, ppos); result = fb_sys_write(info, buf, count, ppos);
if (result > 0) { if (result > 0) {
int start = max((int)(offset / info->fix.line_length) - 1, 0); int start = max((int)(offset / info->fix.line_length), 0);
int lines = min((u32)((result / info->fix.line_length) + 1), int lines = min((u32)((result / info->fix.line_length) + 1),
(u32)info->var.yres); (u32)info->var.yres);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment