Commit 305f6708 authored by Linyu Yuan's avatar Linyu Yuan Committed by Greg Kroah-Hartman

usb: gadget: eem: fix wrong eem header operation

when skb_clone() or skb_copy_expand() fail,
it should pull skb with lengh indicated by header,
or not it will read network data and check it as header.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarLinyu Yuan <linyyuan@codeaurora.com>
Link: https://lore.kernel.org/r/20210608233547.3767-1-linyyuan@codeaurora.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 184fa76b
...@@ -495,7 +495,7 @@ static int eem_unwrap(struct gether *port, ...@@ -495,7 +495,7 @@ static int eem_unwrap(struct gether *port,
skb2 = skb_clone(skb, GFP_ATOMIC); skb2 = skb_clone(skb, GFP_ATOMIC);
if (unlikely(!skb2)) { if (unlikely(!skb2)) {
DBG(cdev, "unable to unframe EEM packet\n"); DBG(cdev, "unable to unframe EEM packet\n");
continue; goto next;
} }
skb_trim(skb2, len - ETH_FCS_LEN); skb_trim(skb2, len - ETH_FCS_LEN);
...@@ -505,7 +505,7 @@ static int eem_unwrap(struct gether *port, ...@@ -505,7 +505,7 @@ static int eem_unwrap(struct gether *port,
GFP_ATOMIC); GFP_ATOMIC);
if (unlikely(!skb3)) { if (unlikely(!skb3)) {
dev_kfree_skb_any(skb2); dev_kfree_skb_any(skb2);
continue; goto next;
} }
dev_kfree_skb_any(skb2); dev_kfree_skb_any(skb2);
skb_queue_tail(list, skb3); skb_queue_tail(list, skb3);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment