Commit 30c1dc0f authored by Tushar Behera's avatar Tushar Behera Committed by Vinod Koul

dmaengine: pl330: dont complete descriptor for cyclic dma

Commit eab21585 ("dmaengine: pl330: dont complete descriptor for
cyclic dma") wrongly completes descriptor for cyclic dma, hence following
BUG_ON is still hit with cyclic DMA operations.

kernel BUG at drivers/dma/dmaengine.h:53!
Signed-off-by: default avatarTushar Behera <tushar.behera@linaro.org>
Acked-by: default avatarJassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: default avatarVinod Koul <vinod.koul@linux.intel.com>
Cc: stable <stable@vger.kernel.org>
parent f8f5701b
......@@ -2321,7 +2321,7 @@ static void pl330_tasklet(unsigned long data)
/* Pick up ripe tomatoes */
list_for_each_entry_safe(desc, _dt, &pch->work_list, node)
if (desc->status == DONE) {
if (pch->cyclic)
if (!pch->cyclic)
dma_cookie_complete(&desc->txd);
list_move_tail(&desc->node, &list);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment