Commit 30ff88e9 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jonathan Cameron

iio: adc: twl4030-madc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-27-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent e4bd0e60
...@@ -892,7 +892,7 @@ static int twl4030_madc_probe(struct platform_device *pdev) ...@@ -892,7 +892,7 @@ static int twl4030_madc_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int twl4030_madc_remove(struct platform_device *pdev) static void twl4030_madc_remove(struct platform_device *pdev)
{ {
struct iio_dev *iio_dev = platform_get_drvdata(pdev); struct iio_dev *iio_dev = platform_get_drvdata(pdev);
struct twl4030_madc_data *madc = iio_priv(iio_dev); struct twl4030_madc_data *madc = iio_priv(iio_dev);
...@@ -903,8 +903,6 @@ static int twl4030_madc_remove(struct platform_device *pdev) ...@@ -903,8 +903,6 @@ static int twl4030_madc_remove(struct platform_device *pdev)
twl4030_madc_set_power(madc, 0); twl4030_madc_set_power(madc, 0);
regulator_disable(madc->usb3v1); regulator_disable(madc->usb3v1);
return 0;
} }
#ifdef CONFIG_OF #ifdef CONFIG_OF
...@@ -917,7 +915,7 @@ MODULE_DEVICE_TABLE(of, twl_madc_of_match); ...@@ -917,7 +915,7 @@ MODULE_DEVICE_TABLE(of, twl_madc_of_match);
static struct platform_driver twl4030_madc_driver = { static struct platform_driver twl4030_madc_driver = {
.probe = twl4030_madc_probe, .probe = twl4030_madc_probe,
.remove = twl4030_madc_remove, .remove_new = twl4030_madc_remove,
.driver = { .driver = {
.name = "twl4030_madc", .name = "twl4030_madc",
.of_match_table = of_match_ptr(twl_madc_of_match), .of_match_table = of_match_ptr(twl_madc_of_match),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment