Commit 312bb849 authored by Alex Elder's avatar Alex Elder Committed by Greg Kroah-Hartman

greybus: endo: drop redundant prefixes from sysfs basenames

This commit:
    7e761e2 endo: rework some attributes
added a new "endo_id" attribute, located under a new "Endo"
directory in sysfs.  The resulting path looks like:
    Documentation/sysfs/endo-TYPE/Endo/endo_id
There's no need to have a separate "Endo" subdirectory to contain
Endo-specific attributes.

That commit also added "svc_" to some other paths related to the
SVC, like:
    Documentation/sysfs/endo-TYPE/SVC/svc_version
The additional "svc_" is redundant.

This patch retouches those paths a bit, mainly to remove some
redundancy.  It also makes the pathname components all lower case.
As a result, the above two paths now look like:
    Documentation/sysfs/endo-TYPE/id
    Documentation/sysfs/endo-TYPE/svc/version

All other Endo sysfs files are updated similarly.
Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 28e3cedc
...@@ -7,7 +7,7 @@ Description: ...@@ -7,7 +7,7 @@ Description:
replaced with the numeric value of the endo layout replaced with the numeric value of the endo layout
scheme as documented in the ARA Module Developer Kit. scheme as documented in the ARA Module Developer Kit.
What: /sys/bus/greybus/device/endo-0xXXXX/Endo/id What: /sys/bus/greybus/device/endo-0xXXXX/id
Date: October 2015 Date: October 2015
KernelVersion: 4.XX KernelVersion: 4.XX
Contact: Greg Kroah-Hartman <greg@kroah.com> Contact: Greg Kroah-Hartman <greg@kroah.com>
...@@ -16,7 +16,7 @@ Description: ...@@ -16,7 +16,7 @@ Description:
defined by the the Endo layout scheme, documented in defined by the the Endo layout scheme, documented in
the ARA Module Developer Kit. the ARA Module Developer Kit.
What: /sys/bus/greybus/device/endo-0xXXXX/Endo/ap_intf_id What: /sys/bus/greybus/device/endo-0xXXXX/ap_intf_id
Date: October 2015 Date: October 2015
KernelVersion: 4.XX KernelVersion: 4.XX
Contact: Greg Kroah-Hartman <greg@kroah.com> Contact: Greg Kroah-Hartman <greg@kroah.com>
...@@ -26,14 +26,14 @@ Description: ...@@ -26,14 +26,14 @@ Description:
The interface positions are defined in the ARA The interface positions are defined in the ARA
Module Developer Kit. Module Developer Kit.
What: /sys/bus/greybus/device/endo-0xXXXX/SVC/serial_number What: /sys/bus/greybus/device/endo-0xXXXX/svc/serial_number
Date: October 2015 Date: October 2015
KernelVersion: 4.XX KernelVersion: 4.XX
Contact: Greg Kroah-Hartman <greg@kroah.com> Contact: Greg Kroah-Hartman <greg@kroah.com>
Description: Description:
The serial number of the SVC device The serial number of the SVC device
What: /sys/bus/greybus/device/endo-0xXXXX/SVC/version What: /sys/bus/greybus/device/endo-0xXXXX/svc/version
Date: October 2015 Date: October 2015
KernelVersion: 4.XX KernelVersion: 4.XX
Contact: Greg Kroah-Hartman <greg@kroah.com> Contact: Greg Kroah-Hartman <greg@kroah.com>
......
...@@ -44,43 +44,43 @@ ...@@ -44,43 +44,43 @@
(4 + ((endo_layout)->max_ribs + 1) * 2) (4 + ((endo_layout)->max_ribs + 1) * 2)
/* endo sysfs attributes */ /* endo sysfs attributes */
static ssize_t svc_serial_number_show(struct device *dev, static ssize_t serial_number_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
struct gb_endo *endo = to_gb_endo(dev); struct gb_endo *endo = to_gb_endo(dev);
return sprintf(buf, "%s", &endo->svc_info.serial_number[0]); return sprintf(buf, "%s", &endo->svc_info.serial_number[0]);
} }
static DEVICE_ATTR_RO(svc_serial_number); static DEVICE_ATTR_RO(serial_number);
static ssize_t svc_version_show(struct device *dev, static ssize_t version_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
struct gb_endo *endo = to_gb_endo(dev); struct gb_endo *endo = to_gb_endo(dev);
return sprintf(buf, "%s", &endo->svc_info.version[0]); return sprintf(buf, "%s", &endo->svc_info.version[0]);
} }
static DEVICE_ATTR_RO(svc_version); static DEVICE_ATTR_RO(version);
static struct attribute *svc_attrs[] = { static struct attribute *svc_attrs[] = {
&dev_attr_svc_serial_number.attr, &dev_attr_serial_number.attr,
&dev_attr_svc_version.attr, &dev_attr_version.attr,
NULL, NULL,
}; };
static const struct attribute_group svc_group = { static const struct attribute_group svc_group = {
.attrs = svc_attrs, .attrs = svc_attrs,
.name = "SVC", .name = "svc",
}; };
static ssize_t endo_id_show(struct device *dev, static ssize_t id_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
struct gb_endo *endo = to_gb_endo(dev); struct gb_endo *endo = to_gb_endo(dev);
return sprintf(buf, "0x%04x", endo->id); return sprintf(buf, "0x%04x", endo->id);
} }
static DEVICE_ATTR_RO(endo_id); static DEVICE_ATTR_RO(id);
static ssize_t ap_intf_id_show(struct device *dev, static ssize_t ap_intf_id_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
...@@ -92,14 +92,13 @@ static ssize_t ap_intf_id_show(struct device *dev, ...@@ -92,14 +92,13 @@ static ssize_t ap_intf_id_show(struct device *dev,
static DEVICE_ATTR_RO(ap_intf_id); static DEVICE_ATTR_RO(ap_intf_id);
static struct attribute *endo_attrs[] = { static struct attribute *endo_attrs[] = {
&dev_attr_endo_id.attr, &dev_attr_id.attr,
&dev_attr_ap_intf_id.attr, &dev_attr_ap_intf_id.attr,
NULL, NULL,
}; };
static const struct attribute_group endo_group = { static const struct attribute_group endo_group = {
.attrs = endo_attrs, .attrs = endo_attrs,
.name = "Endo",
}; };
static const struct attribute_group *endo_groups[] = { static const struct attribute_group *endo_groups[] = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment