Commit 3153bd91 authored by Trent Piepho's avatar Trent Piepho Committed by Mauro Carvalho Chehab

V4L/DVB (5525): Usbvision: fix confusion over 7-bit vs 8-bit TDDA9887 addresses

The code was testing an 8-bit address against a 7-bit address.  Will the
confusion of the two never cease?
Biggest flaw of the I2C protocol:  the R/W bit is the LSB instead of the
MSB.  No one can ever agree if addresses are 7-bits and the R/W bit
follows them, or if they are 8-bit and the R/W bit is OR-ed into the
address byte.  If the R/W bit was first, it wouldn't make any difference!
Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent 66ab6e02
...@@ -278,9 +278,10 @@ static int attach_inform(struct i2c_client *client) ...@@ -278,9 +278,10 @@ static int attach_inform(struct i2c_client *client)
usbvision = i2c_get_adapdata(client->adapter); usbvision = i2c_get_adapdata(client->adapter);
switch (client->addr << 1) { switch (client->addr << 1) {
case 0x86: case 0x42 << 1:
case 0x43: case 0x43 << 1:
case 0x4b: case 0x4a << 1:
case 0x4b << 1:
{ {
struct tuner_setup tun_setup; struct tuner_setup tun_setup;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment