Commit 3168021c authored by Filipe Manana's avatar Filipe Manana

Btrfs: do not create explicit holes when replaying log tree if NO_HOLES enabled

We log holes explicitly by using file extent items, however when replaying
a log tree, if a logged file extent item corresponds to a hole and the
NO_HOLES feature is enabled we do not need to copy the file extent item
into the fs/subvolume tree, as the absence of such file extent items is
the purpose of the NO_HOLES feature. So skip the copying of file extent
items representing holes when the NO_HOLES feature is enabled.
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
parent 91e1f56a
...@@ -673,6 +673,10 @@ static noinline int replay_one_extent(struct btrfs_trans_handle *trans, ...@@ -673,6 +673,10 @@ static noinline int replay_one_extent(struct btrfs_trans_handle *trans,
unsigned long dest_offset; unsigned long dest_offset;
struct btrfs_key ins; struct btrfs_key ins;
if (btrfs_file_extent_disk_bytenr(eb, item) == 0 &&
btrfs_fs_incompat(fs_info, NO_HOLES))
goto update_inode;
ret = btrfs_insert_empty_item(trans, root, path, key, ret = btrfs_insert_empty_item(trans, root, path, key,
sizeof(*item)); sizeof(*item));
if (ret) if (ret)
...@@ -825,6 +829,7 @@ static noinline int replay_one_extent(struct btrfs_trans_handle *trans, ...@@ -825,6 +829,7 @@ static noinline int replay_one_extent(struct btrfs_trans_handle *trans,
} }
inode_add_bytes(inode, nbytes); inode_add_bytes(inode, nbytes);
update_inode:
ret = btrfs_update_inode(trans, root, inode); ret = btrfs_update_inode(trans, root, inode);
out: out:
if (inode) if (inode)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment