Commit 31c4e8cd authored by Xi Wang's avatar Xi Wang Committed by Greg Kroah-Hartman

nfs: fix null checking in nfs_get_option_str()

commit e25fbe38 upstream.

The following null pointer check is broken.

	*option = match_strdup(args);
	return !option;

The pointer `option' must be non-null, and thus `!option' is always false.
Use `!*option' instead.

The bug was introduced in commit c5cb09b6 ("Cleanup: Factor out some
cut-and-paste code.").
Signed-off-by: default avatarXi Wang <xi.wang@gmail.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d6e0c42c
......@@ -1052,7 +1052,7 @@ static int nfs_get_option_str(substring_t args[], char **option)
{
kfree(*option);
*option = match_strdup(args);
return !option;
return !*option;
}
static int nfs_get_option_ul(substring_t args[], unsigned long *option)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment