Commit 323702b4 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mark Brown

ASoC: mmp: Don't set unused struct snd_pcm_hardware fields

The ASoC core assumes that the PCM component of the ASoC card transparently
moves data around and does not impose any restrictions on the memory layout or
the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
the PCM driver that are related to this. Setting these fields in the PCM driver
might suggest otherwise though, so rather not set them.
Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 48b752ac
...@@ -36,14 +36,9 @@ struct mmp_dma_data { ...@@ -36,14 +36,9 @@ struct mmp_dma_data {
SNDRV_PCM_INFO_PAUSE | \ SNDRV_PCM_INFO_PAUSE | \
SNDRV_PCM_INFO_RESUME) SNDRV_PCM_INFO_RESUME)
#define MMP_PCM_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | \
SNDRV_PCM_FMTBIT_S24_LE | \
SNDRV_PCM_FMTBIT_S32_LE)
static struct snd_pcm_hardware mmp_pcm_hardware[] = { static struct snd_pcm_hardware mmp_pcm_hardware[] = {
{ {
.info = MMP_PCM_INFO, .info = MMP_PCM_INFO,
.formats = MMP_PCM_FORMATS,
.period_bytes_min = 1024, .period_bytes_min = 1024,
.period_bytes_max = 2048, .period_bytes_max = 2048,
.periods_min = 2, .periods_min = 2,
...@@ -53,7 +48,6 @@ static struct snd_pcm_hardware mmp_pcm_hardware[] = { ...@@ -53,7 +48,6 @@ static struct snd_pcm_hardware mmp_pcm_hardware[] = {
}, },
{ {
.info = MMP_PCM_INFO, .info = MMP_PCM_INFO,
.formats = MMP_PCM_FORMATS,
.period_bytes_min = 1024, .period_bytes_min = 1024,
.period_bytes_max = 2048, .period_bytes_max = 2048,
.periods_min = 2, .periods_min = 2,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment