Commit 332b49ff authored by David Arinzon's avatar David Arinzon Committed by David S. Miller

net: ena: Fix toeplitz initial hash value

On driver initialization, RSS hash initial value is set to zero,
instead of the default value. This happens because we pass NULL as
the RSS key parameter, which caused us to never initialize
the RSS hash value.

This patch fixes it by making sure the initial value is set, no matter
what the value of the RSS key is.

Fixes: 91a65b7d ("net: ena: fix potential crash when rxfh key is NULL")
Signed-off-by: default avatarNati Koler <nkoler@amazon.com>
Signed-off-by: default avatarDavid Arinzon <darinzon@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1573c688
...@@ -2400,29 +2400,18 @@ int ena_com_fill_hash_function(struct ena_com_dev *ena_dev, ...@@ -2400,29 +2400,18 @@ int ena_com_fill_hash_function(struct ena_com_dev *ena_dev,
return -EOPNOTSUPP; return -EOPNOTSUPP;
} }
switch (func) { if ((func == ENA_ADMIN_TOEPLITZ) && key) {
case ENA_ADMIN_TOEPLITZ: if (key_len != sizeof(hash_key->key)) {
if (key) { netdev_err(ena_dev->net_device,
if (key_len != sizeof(hash_key->key)) { "key len (%u) doesn't equal the supported size (%zu)\n",
netdev_err(ena_dev->net_device, key_len, sizeof(hash_key->key));
"key len (%u) doesn't equal the supported size (%zu)\n", return -EINVAL;
key_len, sizeof(hash_key->key));
return -EINVAL;
}
memcpy(hash_key->key, key, key_len);
rss->hash_init_val = init_val;
hash_key->key_parts = key_len / sizeof(hash_key->key[0]);
} }
break; memcpy(hash_key->key, key, key_len);
case ENA_ADMIN_CRC32: hash_key->key_parts = key_len / sizeof(hash_key->key[0]);
rss->hash_init_val = init_val;
break;
default:
netdev_err(ena_dev->net_device, "Invalid hash function (%d)\n",
func);
return -EINVAL;
} }
rss->hash_init_val = init_val;
old_func = rss->hash_func; old_func = rss->hash_func;
rss->hash_func = func; rss->hash_func = func;
rc = ena_com_set_hash_function(ena_dev); rc = ena_com_set_hash_function(ena_dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment