Commit 333d073d authored by YueHaibing's avatar YueHaibing Committed by Andrew Morton

selftests: cgroup: fix unsigned comparison with less than zero

'size' is unsigned, it never less than zero.

Link: https://lkml.kernel.org/r/20221105110611.28920-1-yuehaibing@huawei.com
Fixes: 6c26df84 ("selftests: cgroup: return -errno from cg_read()/cg_write() on failure")
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Reviewed-by: default avatarYosry Ahmed <yosryahmed@google.com>
Acked-by: default avatarRoman Gushchin <roman.gushchin@linux.dev>
Reviewed-by: default avatarKamalesh Babulal <kamalesh.babulal@oracle.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Shakeel Butt <shakeelb@google.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: zefan li <lizefan.x@bytedance.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent d51cf40d
...@@ -555,6 +555,7 @@ int proc_mount_contains(const char *option) ...@@ -555,6 +555,7 @@ int proc_mount_contains(const char *option)
ssize_t proc_read_text(int pid, bool thread, const char *item, char *buf, size_t size) ssize_t proc_read_text(int pid, bool thread, const char *item, char *buf, size_t size)
{ {
char path[PATH_MAX]; char path[PATH_MAX];
ssize_t ret;
if (!pid) if (!pid)
snprintf(path, sizeof(path), "/proc/%s/%s", snprintf(path, sizeof(path), "/proc/%s/%s",
...@@ -562,8 +563,8 @@ ssize_t proc_read_text(int pid, bool thread, const char *item, char *buf, size_t ...@@ -562,8 +563,8 @@ ssize_t proc_read_text(int pid, bool thread, const char *item, char *buf, size_t
else else
snprintf(path, sizeof(path), "/proc/%d/%s", pid, item); snprintf(path, sizeof(path), "/proc/%d/%s", pid, item);
size = read_text(path, buf, size); ret = read_text(path, buf, size);
return size < 0 ? -1 : size; return ret < 0 ? -1 : ret;
} }
int proc_read_strstr(int pid, bool thread, const char *item, const char *needle) int proc_read_strstr(int pid, bool thread, const char *item, const char *needle)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment