Commit 33812fc7 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Jiri Kosina

HID: magicmouse: Fix an error handling path in magicmouse_probe()

If the timer introduced by the commit below is started, then it must be
deleted in the error handling of the probe. Otherwise it would trigger
once the driver is no more.

Fixes: 0b91b4e4 ("HID: magicmouse: Report battery level over USB")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tested-by: default avatarJosé Expósito <jose.exposito89@gmail.com>
Reported-by: <syzbot+a437546ec71b04dfb5ac@syzkaller.appspotmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 0b91b4e4
......@@ -870,6 +870,7 @@ static int magicmouse_probe(struct hid_device *hdev,
return 0;
err_stop_hw:
del_timer_sync(&msc->battery_timer);
hid_hw_stop(hdev);
return ret;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment