Commit 33c40e24 authored by David Howells's avatar David Howells Committed by David S. Miller

rxrpc: Correctly handle ack at end of client call transmit phase

Normally, the transmit phase of a client call is implicitly ack'd by the
reception of the first data packet of the response being received.
However, if a security negotiation happens, the transmit phase, if it is
entirely contained in a single packet, may get an ack packet in response
and then may get aborted due to security negotiation failure.

Because the client has shifted state to RXRPC_CALL_CLIENT_AWAIT_REPLY due
to having transmitted all the data, the code that handles processing of the
received ack packet doesn't note the hard ack the data packet.

The following abort packet in the case of security negotiation failure then
incurs an assertion failure when it tries to drain the Tx queue because the
hard ack state is out of sync (hard ack means the packets have been
processed and can be discarded by the sender; a soft ack means that the
packets are received but could still be discarded and rerequested by the
receiver).

To fix this, we should record the hard ack we received for the ack packet.

The assertion failure looks like:

	RxRPC: Assertion failed
	1 <= 0 is false
	0x1 <= 0x0 is false
	------------[ cut here ]------------
	kernel BUG at ../net/rxrpc/ar-ack.c:431!
	...
	RIP: 0010:[<ffffffffa006857b>]  [<ffffffffa006857b>] rxrpc_rotate_tx_window+0xbc/0x131 [af_rxrpc]
	...
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 264640fc
...@@ -723,8 +723,10 @@ static int rxrpc_process_rx_queue(struct rxrpc_call *call, ...@@ -723,8 +723,10 @@ static int rxrpc_process_rx_queue(struct rxrpc_call *call,
if ((call->state == RXRPC_CALL_CLIENT_AWAIT_REPLY || if ((call->state == RXRPC_CALL_CLIENT_AWAIT_REPLY ||
call->state == RXRPC_CALL_SERVER_AWAIT_ACK) && call->state == RXRPC_CALL_SERVER_AWAIT_ACK) &&
hard > tx) hard > tx) {
call->acks_hard = tx;
goto all_acked; goto all_acked;
}
smp_rmb(); smp_rmb();
rxrpc_rotate_tx_window(call, hard - 1); rxrpc_rotate_tx_window(call, hard - 1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment