Commit 34b46efd authored by Changcheng Deng's avatar Changcheng Deng Committed by Linus Torvalds

lib/test_vmalloc.c: use swap() to make code cleaner

Use swap() in order to make code cleaner.  Issue found by coccinelle.

Link: https://lkml.kernel.org/r/20211028111443.15744-1-deng.changcheng@zte.com.cnSigned-off-by: default avatarChangcheng Deng <deng.changcheng@zte.com.cn>
Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Reviewed-by: default avatarUladzislau Rezki (Sony) <urezki@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c00b6b96
...@@ -393,7 +393,7 @@ static struct test_driver { ...@@ -393,7 +393,7 @@ static struct test_driver {
static void shuffle_array(int *arr, int n) static void shuffle_array(int *arr, int n)
{ {
unsigned int rnd; unsigned int rnd;
int i, j, x; int i, j;
for (i = n - 1; i > 0; i--) { for (i = n - 1; i > 0; i--) {
get_random_bytes(&rnd, sizeof(rnd)); get_random_bytes(&rnd, sizeof(rnd));
...@@ -402,9 +402,7 @@ static void shuffle_array(int *arr, int n) ...@@ -402,9 +402,7 @@ static void shuffle_array(int *arr, int n)
j = rnd % i; j = rnd % i;
/* Swap indexes. */ /* Swap indexes. */
x = arr[i]; swap(arr[i], arr[j]);
arr[i] = arr[j];
arr[j] = x;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment