Commit 34e7434b authored by Zou Wei's avatar Zou Wei Committed by David S. Miller

atm: nicstar: Fix possible use-after-free in nicstar_cleanup()

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZou Wei <zou_wei@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent faa5f5da
...@@ -299,7 +299,7 @@ static void __exit nicstar_cleanup(void) ...@@ -299,7 +299,7 @@ static void __exit nicstar_cleanup(void)
{ {
XPRINTK("nicstar: nicstar_cleanup() called.\n"); XPRINTK("nicstar: nicstar_cleanup() called.\n");
del_timer(&ns_timer); del_timer_sync(&ns_timer);
pci_unregister_driver(&nicstar_driver); pci_unregister_driver(&nicstar_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment