Commit 34fb8412 authored by Benjamin Herrenschmidt's avatar Benjamin Herrenschmidt Committed by Linus Torvalds

[PATCH] ppc64: Workaround PCI issue on g5

ppc64 has a global called "pci_probe_only" which, when set, prevents the
arch PCI code from calling pci_assign_unassigned_resources().  This was
cleared by pmac so far, but a bug in the definition of the variable make
that ineffective until 2.6.10, and so we never called
pci_assign_unassigned_resources().

With 2.6.10, that bug was fixed and so we now call it, which results in
some problems.  Some devices who have perfectly valid assigned addresses by
firmware end up beeing moved around anyway, which is a BAD thing can can
break boot on some machines since it breaks the relationship between
addresses in Open Firmware device-tree and actual location of PCI devices. 
(Some low level things like the PIC are ioremap'ed based on their OF
address, way before the PCI based ASIC hosting them has been found).  This
also break the "offb" default framebuffer driver since the video card ends
up beeing moved around as well.

For now, the fix is to set pci_probe_only on pmac, thus reverting to the
old behaviour.  In the long run, it would be interesting to "fix"
pci_assign_unassigned_resources() so that it does what it's name claims,
and only assigns things that have been left unassigned instead of moving
things around gratuituously...
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 2f16b7a1
...@@ -739,8 +739,8 @@ void __init pmac_pci_init(void) ...@@ -739,8 +739,8 @@ void __init pmac_pci_init(void)
pmac_check_ht_link(); pmac_check_ht_link();
/* Tell pci.c to use the common resource allocation mecanism */ /* Tell pci.c to not use the common resource allocation mecanism */
pci_probe_only = 0; pci_probe_only = 1;
/* Allow all IO */ /* Allow all IO */
io_page_mask = -1; io_page_mask = -1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment