Commit 351d6204 authored by Qixue Xiao's avatar Qixue Xiao Committed by Greg Kroah-Hartman

tty: an overflow of multiplication in drivers/tty/cyclades.c

there is an overflow in the code :
cyz_polling_cycle = (arg * HZ) / 1000,
the multiplicator arg comes from user, so it may be an overflow if
arg is a big number. And the value of cyc_polling_cycle will be
wrong when it is used next time.
Reported-by: default avatarQixue Xiao <xiaoqixue_1@163.com>
Suggested-by: default avatarYongjian Xu <xuyongjiande@gmail.com>
Suggested-by: default avatarYu Chen <chyyuu@gmail.com>
Signed-off-by: default avatarQixue Xiao <xiaoqixue_1@163.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4903713c
...@@ -2709,6 +2709,8 @@ cy_ioctl(struct tty_struct *tty, ...@@ -2709,6 +2709,8 @@ cy_ioctl(struct tty_struct *tty,
break; break;
#ifndef CONFIG_CYZ_INTR #ifndef CONFIG_CYZ_INTR
case CYZSETPOLLCYCLE: case CYZSETPOLLCYCLE:
if (arg > LONG_MAX / HZ)
return -ENODEV;
cyz_polling_cycle = (arg * HZ) / 1000; cyz_polling_cycle = (arg * HZ) / 1000;
break; break;
case CYZGETPOLLCYCLE: case CYZGETPOLLCYCLE:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment