Commit 355cced4 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Dave Chinner

xfs: always set rvalp in xfs_dir2_node_trim_free

xfs_dir2_node_trim_free can return with setting the rvalp argument
pointer.  Initialize it to 0 at the beginning of the function and
only update it to 1 if we succeeded trimming a freespace block.
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent cc07eed8
...@@ -2235,6 +2235,9 @@ xfs_dir2_node_trim_free( ...@@ -2235,6 +2235,9 @@ xfs_dir2_node_trim_free(
dp = args->dp; dp = args->dp;
tp = args->trans; tp = args->trans;
*rvalp = 0;
/* /*
* Read the freespace block. * Read the freespace block.
*/ */
...@@ -2255,7 +2258,6 @@ xfs_dir2_node_trim_free( ...@@ -2255,7 +2258,6 @@ xfs_dir2_node_trim_free(
*/ */
if (freehdr.nused > 0) { if (freehdr.nused > 0) {
xfs_trans_brelse(tp, bp); xfs_trans_brelse(tp, bp);
*rvalp = 0;
return 0; return 0;
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment