Commit 35fdc390 authored by Stefan Wahren's avatar Stefan Wahren Committed by Guenter Roeck

hwmon: (raspberrypi) Fix initial notify

In case an under-voltage happens before probing the driver wont
write the critical warning into the kernel log. So don't init
of last_throttled during probe and fix this issue.

Fixes: 74d1e007 ("hwmon: Add support for RPi voltage sensor")
Reported-by: default avatar"Noralf Trønnes" <noralf@tronnes.org>
Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 70df9ebb
...@@ -115,7 +115,6 @@ static int rpi_hwmon_probe(struct platform_device *pdev) ...@@ -115,7 +115,6 @@ static int rpi_hwmon_probe(struct platform_device *pdev)
{ {
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct rpi_hwmon_data *data; struct rpi_hwmon_data *data;
int ret;
data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
if (!data) if (!data)
...@@ -124,11 +123,6 @@ static int rpi_hwmon_probe(struct platform_device *pdev) ...@@ -124,11 +123,6 @@ static int rpi_hwmon_probe(struct platform_device *pdev)
/* Parent driver assure that firmware is correct */ /* Parent driver assure that firmware is correct */
data->fw = dev_get_drvdata(dev->parent); data->fw = dev_get_drvdata(dev->parent);
/* Init throttled */
ret = rpi_firmware_property(data->fw, RPI_FIRMWARE_GET_THROTTLED,
&data->last_throttled,
sizeof(data->last_throttled));
data->hwmon_dev = devm_hwmon_device_register_with_info(dev, "rpi_volt", data->hwmon_dev = devm_hwmon_device_register_with_info(dev, "rpi_volt",
data, data,
&rpi_chip_info, &rpi_chip_info,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment