Commit 363d53ac authored by Marek Vasut's avatar Marek Vasut Committed by Bjorn Helgaas

PCI: dwc: Silence 'set affinity failed' warning

Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows
migrate_one_irq() to exit right away, without warnings like this:

  IRQ...: set affinity failed(-22)

Remove the .irq_set_affinity() implementation that is no longer needed.

Link: https://lore.kernel.org/r/20240723132958.41320-6-marek.vasut+renesas@mailbox.orgSigned-off-by: default avatarMarek Vasut <marek.vasut+renesas@mailbox.org>
[bhelgaas: commit log]
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent c7b10edd
...@@ -189,12 +189,6 @@ static void ks_pcie_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) ...@@ -189,12 +189,6 @@ static void ks_pcie_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
(int)data->hwirq, msg->address_hi, msg->address_lo); (int)data->hwirq, msg->address_hi, msg->address_lo);
} }
static int ks_pcie_msi_set_affinity(struct irq_data *irq_data,
const struct cpumask *mask, bool force)
{
return -EINVAL;
}
static void ks_pcie_msi_mask(struct irq_data *data) static void ks_pcie_msi_mask(struct irq_data *data)
{ {
struct dw_pcie_rp *pp = irq_data_get_irq_chip_data(data); struct dw_pcie_rp *pp = irq_data_get_irq_chip_data(data);
...@@ -247,7 +241,6 @@ static struct irq_chip ks_pcie_msi_irq_chip = { ...@@ -247,7 +241,6 @@ static struct irq_chip ks_pcie_msi_irq_chip = {
.name = "KEYSTONE-PCI-MSI", .name = "KEYSTONE-PCI-MSI",
.irq_ack = ks_pcie_msi_irq_ack, .irq_ack = ks_pcie_msi_irq_ack,
.irq_compose_msi_msg = ks_pcie_compose_msi_msg, .irq_compose_msi_msg = ks_pcie_compose_msi_msg,
.irq_set_affinity = ks_pcie_msi_set_affinity,
.irq_mask = ks_pcie_msi_mask, .irq_mask = ks_pcie_msi_mask,
.irq_unmask = ks_pcie_msi_unmask, .irq_unmask = ks_pcie_msi_unmask,
}; };
......
...@@ -48,8 +48,9 @@ static struct irq_chip dw_pcie_msi_irq_chip = { ...@@ -48,8 +48,9 @@ static struct irq_chip dw_pcie_msi_irq_chip = {
}; };
static struct msi_domain_info dw_pcie_msi_domain_info = { static struct msi_domain_info dw_pcie_msi_domain_info = {
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
MSI_FLAG_PCI_MSIX | MSI_FLAG_MULTI_PCI_MSI), MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX |
MSI_FLAG_MULTI_PCI_MSI,
.chip = &dw_pcie_msi_irq_chip, .chip = &dw_pcie_msi_irq_chip,
}; };
...@@ -116,12 +117,6 @@ static void dw_pci_setup_msi_msg(struct irq_data *d, struct msi_msg *msg) ...@@ -116,12 +117,6 @@ static void dw_pci_setup_msi_msg(struct irq_data *d, struct msi_msg *msg)
(int)d->hwirq, msg->address_hi, msg->address_lo); (int)d->hwirq, msg->address_hi, msg->address_lo);
} }
static int dw_pci_msi_set_affinity(struct irq_data *d,
const struct cpumask *mask, bool force)
{
return -EINVAL;
}
static void dw_pci_bottom_mask(struct irq_data *d) static void dw_pci_bottom_mask(struct irq_data *d)
{ {
struct dw_pcie_rp *pp = irq_data_get_irq_chip_data(d); struct dw_pcie_rp *pp = irq_data_get_irq_chip_data(d);
...@@ -177,7 +172,6 @@ static struct irq_chip dw_pci_msi_bottom_irq_chip = { ...@@ -177,7 +172,6 @@ static struct irq_chip dw_pci_msi_bottom_irq_chip = {
.name = "DWPCI-MSI", .name = "DWPCI-MSI",
.irq_ack = dw_pci_bottom_ack, .irq_ack = dw_pci_bottom_ack,
.irq_compose_msi_msg = dw_pci_setup_msi_msg, .irq_compose_msi_msg = dw_pci_setup_msi_msg,
.irq_set_affinity = dw_pci_msi_set_affinity,
.irq_mask = dw_pci_bottom_mask, .irq_mask = dw_pci_bottom_mask,
.irq_unmask = dw_pci_bottom_unmask, .irq_unmask = dw_pci_bottom_unmask,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment