Commit 37d1e62b authored by Yizhuo's avatar Yizhuo Committed by Mauro Carvalho Chehab

media: ts2020: Variable "utmp" in function ts2020_set_tuner_rf() could be uninitialized

In function ts2020_set_tuner_rf(), local variable "utmp" could
be uninitialized if function regmap_read() returns -EINVAL.
However, this value is used in if statement and written to
the register, which is potentially unsafe.
Signed-off-by: default avatarYizhuo <yzhai003@ucr.edu>
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 1e98a840
...@@ -180,6 +180,9 @@ static int ts2020_set_tuner_rf(struct dvb_frontend *fe) ...@@ -180,6 +180,9 @@ static int ts2020_set_tuner_rf(struct dvb_frontend *fe)
unsigned int utmp; unsigned int utmp;
ret = regmap_read(dev->regmap, 0x3d, &utmp); ret = regmap_read(dev->regmap, 0x3d, &utmp);
if (ret)
return ret;
utmp &= 0x7f; utmp &= 0x7f;
if (utmp < 0x16) if (utmp < 0x16)
utmp = 0xa1; utmp = 0xa1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment