Commit 39be23f4 authored by Peter Chen's avatar Peter Chen

usb: cdns3: trace: delete the trace parameter for request->trb

It is not correct using %pa to print virtual address of request->trb, and
it is hard to print its physical address due to the virtual address is
zero before using. It could use index (start_trb/end_trb) to know the
current trb position, so no matter virtual address or physical address
for request-trb is not so meaningful.
Reported-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Signed-off-by: default avatarPeter Chen <peter.chen@kernel.org>
parent 2fd69eca
...@@ -214,7 +214,6 @@ DECLARE_EVENT_CLASS(cdns3_log_request, ...@@ -214,7 +214,6 @@ DECLARE_EVENT_CLASS(cdns3_log_request,
__field(int, no_interrupt) __field(int, no_interrupt)
__field(int, start_trb) __field(int, start_trb)
__field(int, end_trb) __field(int, end_trb)
__field(struct cdns3_trb *, start_trb_addr)
__field(int, flags) __field(int, flags)
__field(unsigned int, stream_id) __field(unsigned int, stream_id)
), ),
...@@ -230,12 +229,11 @@ DECLARE_EVENT_CLASS(cdns3_log_request, ...@@ -230,12 +229,11 @@ DECLARE_EVENT_CLASS(cdns3_log_request,
__entry->no_interrupt = req->request.no_interrupt; __entry->no_interrupt = req->request.no_interrupt;
__entry->start_trb = req->start_trb; __entry->start_trb = req->start_trb;
__entry->end_trb = req->end_trb; __entry->end_trb = req->end_trb;
__entry->start_trb_addr = req->trb;
__entry->flags = req->flags; __entry->flags = req->flags;
__entry->stream_id = req->request.stream_id; __entry->stream_id = req->request.stream_id;
), ),
TP_printk("%s: req: %p, req buff %p, length: %u/%u %s%s%s, status: %d," TP_printk("%s: req: %p, req buff %p, length: %u/%u %s%s%s, status: %d,"
" trb: [start:%d, end:%d: virt addr %pa], flags:%x SID: %u", " trb: [start:%d, end:%d], flags:%x SID: %u",
__get_str(name), __entry->req, __entry->buf, __entry->actual, __get_str(name), __entry->req, __entry->buf, __entry->actual,
__entry->length, __entry->length,
__entry->zero ? "Z" : "z", __entry->zero ? "Z" : "z",
...@@ -244,7 +242,6 @@ DECLARE_EVENT_CLASS(cdns3_log_request, ...@@ -244,7 +242,6 @@ DECLARE_EVENT_CLASS(cdns3_log_request,
__entry->status, __entry->status,
__entry->start_trb, __entry->start_trb,
__entry->end_trb, __entry->end_trb,
__entry->start_trb_addr,
__entry->flags, __entry->flags,
__entry->stream_id __entry->stream_id
) )
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment