Commit 3a98cd6b authored by Peter Ujfalusi's avatar Peter Ujfalusi

ASoC: OMAP4: McPDM: Convert to hwmod/omap_device

In order to probe, and operate correctly, the OMAP McPDM driver needs to
be converted to use hwmod.
The device name has been changed to probe the driver.
Replace the clk_* with pm_runtime_* calls to manage the clocks correctly.
Missing request_mem_region/release_mem_region added.
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: default avatarLiam Girdwood <lrg@ti.com>
parent b199adfd
...@@ -28,7 +28,7 @@ ...@@ -28,7 +28,7 @@
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/interrupt.h> #include <linux/interrupt.h>
#include <linux/err.h> #include <linux/err.h>
#include <linux/clk.h> #include <linux/pm_runtime.h>
#include <linux/delay.h> #include <linux/delay.h>
#include <linux/io.h> #include <linux/io.h>
#include <linux/irq.h> #include <linux/irq.h>
...@@ -322,11 +322,11 @@ static irqreturn_t omap_mcpdm_irq_handler(int irq, void *dev_id) ...@@ -322,11 +322,11 @@ static irqreturn_t omap_mcpdm_irq_handler(int irq, void *dev_id)
return IRQ_HANDLED; return IRQ_HANDLED;
} }
int omap_mcpdm_request(void) int omap_mcpdm_request(void)
{ {
int ret; int ret;
clk_enable(mcpdm->clk); pm_runtime_get_sync(mcpdm->dev);
spin_lock(&mcpdm->lock); spin_lock(&mcpdm->lock);
...@@ -353,7 +353,8 @@ int omap_mcpdm_request(void) ...@@ -353,7 +353,8 @@ int omap_mcpdm_request(void)
return 0; return 0;
err: err:
clk_disable(mcpdm->clk); mcpdm->free = 1;
pm_runtime_put_sync(mcpdm->dev);
return ret; return ret;
} }
...@@ -368,7 +369,7 @@ void omap_mcpdm_free(void) ...@@ -368,7 +369,7 @@ void omap_mcpdm_free(void)
mcpdm->free = 1; mcpdm->free = 1;
spin_unlock(&mcpdm->lock); spin_unlock(&mcpdm->lock);
clk_disable(mcpdm->clk); pm_runtime_put_sync(mcpdm->dev);
free_irq(mcpdm->irq, (void *)mcpdm); free_irq(mcpdm->irq, (void *)mcpdm);
} }
...@@ -421,28 +422,29 @@ int __devinit omap_mcpdm_probe(struct platform_device *pdev) ...@@ -421,28 +422,29 @@ int __devinit omap_mcpdm_probe(struct platform_device *pdev)
spin_lock_init(&mcpdm->lock); spin_lock_init(&mcpdm->lock);
mcpdm->free = 1; mcpdm->free = 1;
if (!request_mem_region(res->start, resource_size(res), "McPDM")) {
ret = -EBUSY;
goto err_resource;
}
mcpdm->io_base = ioremap(res->start, resource_size(res)); mcpdm->io_base = ioremap(res->start, resource_size(res));
if (!mcpdm->io_base) { if (!mcpdm->io_base) {
ret = -ENOMEM; ret = -ENOMEM;
goto err_resource; goto err_remap;
} }
mcpdm->irq = platform_get_irq(pdev, 0); mcpdm->irq = platform_get_irq(pdev, 0);
mcpdm->clk = clk_get(&pdev->dev, "pdm_ck");
if (IS_ERR(mcpdm->clk)) {
ret = PTR_ERR(mcpdm->clk);
dev_err(&pdev->dev, "unable to get pdm_ck: %d\n", ret);
goto err_clk;
}
mcpdm->dev = &pdev->dev; mcpdm->dev = &pdev->dev;
platform_set_drvdata(pdev, mcpdm); platform_set_drvdata(pdev, mcpdm);
pm_runtime_enable(mcpdm->dev);
return 0; return 0;
err_clk: err_remap:
iounmap(mcpdm->io_base); release_mem_region(res->start, resource_size(res));
err_resource: err_resource:
kfree(mcpdm); kfree(mcpdm);
exit: exit:
...@@ -452,14 +454,16 @@ int __devinit omap_mcpdm_probe(struct platform_device *pdev) ...@@ -452,14 +454,16 @@ int __devinit omap_mcpdm_probe(struct platform_device *pdev)
int __devexit omap_mcpdm_remove(struct platform_device *pdev) int __devexit omap_mcpdm_remove(struct platform_device *pdev)
{ {
struct omap_mcpdm *mcpdm_ptr = platform_get_drvdata(pdev); struct omap_mcpdm *mcpdm_ptr = platform_get_drvdata(pdev);
struct resource *res;
platform_set_drvdata(pdev, NULL); platform_set_drvdata(pdev, NULL);
clk_put(mcpdm_ptr->clk); pm_runtime_disable(mcpdm_ptr->dev);
iounmap(mcpdm_ptr->io_base); iounmap(mcpdm_ptr->io_base);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
release_mem_region(res->start, resource_size(res));
mcpdm_ptr->clk = NULL;
mcpdm_ptr->free = 0; mcpdm_ptr->free = 0;
mcpdm_ptr->dev = NULL; mcpdm_ptr->dev = NULL;
......
...@@ -131,7 +131,6 @@ struct omap_mcpdm { ...@@ -131,7 +131,6 @@ struct omap_mcpdm {
spinlock_t lock; spinlock_t lock;
struct omap_mcpdm_platform_data *pdata; struct omap_mcpdm_platform_data *pdata;
struct clk *clk;
struct omap_mcpdm_link *downlink; struct omap_mcpdm_link *downlink;
struct omap_mcpdm_link *uplink; struct omap_mcpdm_link *uplink;
struct completion irq_completion; struct completion irq_completion;
......
...@@ -254,7 +254,7 @@ static int __devexit asoc_mcpdm_remove(struct platform_device *pdev) ...@@ -254,7 +254,7 @@ static int __devexit asoc_mcpdm_remove(struct platform_device *pdev)
static struct platform_driver asoc_mcpdm_driver = { static struct platform_driver asoc_mcpdm_driver = {
.driver = { .driver = {
.name = "omap-mcpdm-dai", .name = "omap-mcpdm",
.owner = THIS_MODULE, .owner = THIS_MODULE,
}, },
......
...@@ -165,7 +165,7 @@ static int sdp4430_twl6040_init(struct snd_soc_pcm_runtime *rtd) ...@@ -165,7 +165,7 @@ static int sdp4430_twl6040_init(struct snd_soc_pcm_runtime *rtd)
static struct snd_soc_dai_link sdp4430_dai = { static struct snd_soc_dai_link sdp4430_dai = {
.name = "TWL6040", .name = "TWL6040",
.stream_name = "TWL6040", .stream_name = "TWL6040",
.cpu_dai_name ="omap-mcpdm-dai", .cpu_dai_name = "omap-mcpdm",
.codec_dai_name = "twl6040-hifi", .codec_dai_name = "twl6040-hifi",
.platform_name = "omap-pcm-audio", .platform_name = "omap-pcm-audio",
.codec_name = "twl6040-codec", .codec_name = "twl6040-codec",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment