Commit 3a9b153c authored by Qing Xu's avatar Qing Xu Committed by Kalle Valo

mwifiex: Fix possible buffer overflows in mwifiex_ret_wmm_get_status()

mwifiex_ret_wmm_get_status() calls memcpy() without checking the
destination size.Since the source is given from remote AP which
contains illegal wmm elements , this may trigger a heap buffer
overflow.
Fix it by putting the length check before calling memcpy().
Signed-off-by: default avatarQing Xu <m1s5p6688@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 65b1aae0
...@@ -970,6 +970,10 @@ int mwifiex_ret_wmm_get_status(struct mwifiex_private *priv, ...@@ -970,6 +970,10 @@ int mwifiex_ret_wmm_get_status(struct mwifiex_private *priv,
"WMM Parameter Set Count: %d\n", "WMM Parameter Set Count: %d\n",
wmm_param_ie->qos_info_bitmap & mask); wmm_param_ie->qos_info_bitmap & mask);
if (wmm_param_ie->vend_hdr.len + 2 >
sizeof(struct ieee_types_wmm_parameter))
break;
memcpy((u8 *) &priv->curr_bss_params.bss_descriptor. memcpy((u8 *) &priv->curr_bss_params.bss_descriptor.
wmm_ie, wmm_param_ie, wmm_ie, wmm_param_ie,
wmm_param_ie->vend_hdr.len + 2); wmm_param_ie->vend_hdr.len + 2);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment