Commit 3b1b5291 authored by Sheng Yong's avatar Sheng Yong Committed by Greg Kroah-Hartman

staging: erofs: fix memleak of inode's shared xattr array

If it fails to read a shared xattr page, the inode's shared xattr array
is not freed. The next time the inode's xattr is accessed, the previously
allocated array is leaked.
Signed-off-by: default avatarSheng Yong <shengyong1@huawei.com>
Fixes: b17500a0 ("staging: erofs: introduce xattr & acl support")
Cc: <stable@vger.kernel.org> # 4.19+
Reviewed-by: default avatarGao Xiang <gaoxiang25@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e7dd3d47
...@@ -111,8 +111,11 @@ static int init_inode_xattrs(struct inode *inode) ...@@ -111,8 +111,11 @@ static int init_inode_xattrs(struct inode *inode)
it.page = erofs_get_meta_page(sb, it.page = erofs_get_meta_page(sb,
++it.blkaddr, S_ISDIR(inode->i_mode)); ++it.blkaddr, S_ISDIR(inode->i_mode));
if (IS_ERR(it.page)) if (IS_ERR(it.page)) {
kfree(vi->xattr_shared_xattrs);
vi->xattr_shared_xattrs = NULL;
return PTR_ERR(it.page); return PTR_ERR(it.page);
}
it.kaddr = kmap_atomic(it.page); it.kaddr = kmap_atomic(it.page);
atomic_map = true; atomic_map = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment