Commit 3b4c5cbf authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by David S. Miller

sh_eth: check platform data pointer

Check the platform data pointer before dereferencing it and error out of the
probe() method if it's NULL.

This has additional effect of preventing kernel oops with outdated platform data
containing zero PHY address instead (such as on SolutionEngine7710).
Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: default avatarSimon Horman <horms+renesas@verge.net.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6f9fed0b
...@@ -2663,6 +2663,12 @@ static int sh_eth_drv_probe(struct platform_device *pdev) ...@@ -2663,6 +2663,12 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
pm_runtime_enable(&pdev->dev); pm_runtime_enable(&pdev->dev);
pm_runtime_resume(&pdev->dev); pm_runtime_resume(&pdev->dev);
if (!pd) {
dev_err(&pdev->dev, "no platform data\n");
ret = -EINVAL;
goto out_release;
}
/* get PHY ID */ /* get PHY ID */
mdp->phy_id = pd->phy; mdp->phy_id = pd->phy;
mdp->phy_interface = pd->phy_interface; mdp->phy_interface = pd->phy_interface;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment