Commit 3b5923f0 authored by Zhu Yanjun's avatar Zhu Yanjun Committed by David S. Miller

rds: fix memory leak error

When the function register_netdevice_notifier fails, the memory
allocated by kmem_cache_create should be freed by the function
kmem_cache_destroy.

Cc: Joe Jin <joe.jin@oracle.com>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@oracle.com>
Acked-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
Acked-by: default avatarSowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1158632b
...@@ -641,12 +641,12 @@ static int rds_tcp_init(void) ...@@ -641,12 +641,12 @@ static int rds_tcp_init(void)
ret = register_netdevice_notifier(&rds_tcp_dev_notifier); ret = register_netdevice_notifier(&rds_tcp_dev_notifier);
if (ret) { if (ret) {
pr_warn("could not register rds_tcp_dev_notifier\n"); pr_warn("could not register rds_tcp_dev_notifier\n");
goto out; goto out_slab;
} }
ret = register_pernet_subsys(&rds_tcp_net_ops); ret = register_pernet_subsys(&rds_tcp_net_ops);
if (ret) if (ret)
goto out_slab; goto out_notifier;
ret = rds_tcp_recv_init(); ret = rds_tcp_recv_init();
if (ret) if (ret)
...@@ -664,9 +664,10 @@ static int rds_tcp_init(void) ...@@ -664,9 +664,10 @@ static int rds_tcp_init(void)
rds_tcp_recv_exit(); rds_tcp_recv_exit();
out_pernet: out_pernet:
unregister_pernet_subsys(&rds_tcp_net_ops); unregister_pernet_subsys(&rds_tcp_net_ops);
out_slab: out_notifier:
if (unregister_netdevice_notifier(&rds_tcp_dev_notifier)) if (unregister_netdevice_notifier(&rds_tcp_dev_notifier))
pr_warn("could not unregister rds_tcp_dev_notifier\n"); pr_warn("could not unregister rds_tcp_dev_notifier\n");
out_slab:
kmem_cache_destroy(rds_tcp_conn_slab); kmem_cache_destroy(rds_tcp_conn_slab);
out: out:
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment