Commit 3b69bb31 authored by Felix Fietkau's avatar Felix Fietkau Committed by Jiri Slaby

MIPS: IRQ: Fix disable_irq on CPU IRQs

commit a3e6c1ef upstream.

If the irq_chip does not define .irq_disable, any call to disable_irq
will defer disabling the IRQ until it fires while marked as disabled.
This assumes that the handler function checks for this condition, which
handle_percpu_irq does not. In this case, calling disable_irq leads to
an IRQ storm, if the interrupt fires while disabled.

This optimization is only useful when disabling the IRQ is slow, which
is not true for the MIPS CPU IRQ.

Disable this optimization by implementing .irq_disable and .irq_enable
Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/8949/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent 2d4b4e6e
...@@ -56,6 +56,8 @@ static struct irq_chip mips_cpu_irq_controller = { ...@@ -56,6 +56,8 @@ static struct irq_chip mips_cpu_irq_controller = {
.irq_mask_ack = mask_mips_irq, .irq_mask_ack = mask_mips_irq,
.irq_unmask = unmask_mips_irq, .irq_unmask = unmask_mips_irq,
.irq_eoi = unmask_mips_irq, .irq_eoi = unmask_mips_irq,
.irq_disable = mask_mips_irq,
.irq_enable = unmask_mips_irq,
}; };
/* /*
...@@ -92,6 +94,8 @@ static struct irq_chip mips_mt_cpu_irq_controller = { ...@@ -92,6 +94,8 @@ static struct irq_chip mips_mt_cpu_irq_controller = {
.irq_mask_ack = mips_mt_cpu_irq_ack, .irq_mask_ack = mips_mt_cpu_irq_ack,
.irq_unmask = unmask_mips_irq, .irq_unmask = unmask_mips_irq,
.irq_eoi = unmask_mips_irq, .irq_eoi = unmask_mips_irq,
.irq_disable = mask_mips_irq,
.irq_enable = unmask_mips_irq,
}; };
void __init mips_cpu_irq_init(void) void __init mips_cpu_irq_init(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment