Commit 3bd53269 authored by Wang Xiayang's avatar Wang Xiayang Committed by Alex Deucher

drm/amdgpu: replace simple_strtol() by kstrtou32()

The simple_strtol() function is deprecated. kstrto[l,u32]() is
the correct replacement as it can properly handle overflows.

This patch replaces the deprecated simple_strtol() use introduced recently.
As clk is of type uint32_t, we are safe to use kstrtou32().

It is also safe to return zero on string parsing error,
similar to the case of returning zero if buf is empty in parse_clk().

Fixes: bb5a2bdf ("drm/amdgpu: support dpm level modification under virtualization v3")
Signed-off-by: default avatarWang Xiayang <xywang.sjtu@sjtu.edu.cn>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 5db7b0d2
...@@ -390,7 +390,8 @@ static uint32_t parse_clk(char *buf, bool min) ...@@ -390,7 +390,8 @@ static uint32_t parse_clk(char *buf, bool min)
if (!ptr) if (!ptr)
break; break;
ptr+=2; ptr+=2;
clk = simple_strtoul(ptr, NULL, 10); if (kstrtou32(ptr, 10, &clk))
return 0;
} while (!min); } while (!min);
return clk * 100; return clk * 100;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment