Commit 3bec63db authored by Trond Myklebust's avatar Trond Myklebust

NFS: Convert struct nfs_open_context to use a kref

Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent edc05fc1
...@@ -461,7 +461,6 @@ static struct nfs_open_context *alloc_nfs_open_context(struct vfsmount *mnt, str ...@@ -461,7 +461,6 @@ static struct nfs_open_context *alloc_nfs_open_context(struct vfsmount *mnt, str
ctx = kmalloc(sizeof(*ctx), GFP_KERNEL); ctx = kmalloc(sizeof(*ctx), GFP_KERNEL);
if (ctx != NULL) { if (ctx != NULL) {
atomic_set(&ctx->count, 1);
ctx->path.dentry = dget(dentry); ctx->path.dentry = dget(dentry);
ctx->path.mnt = mntget(mnt); ctx->path.mnt = mntget(mnt);
ctx->cred = get_rpccred(cred); ctx->cred = get_rpccred(cred);
...@@ -469,6 +468,7 @@ static struct nfs_open_context *alloc_nfs_open_context(struct vfsmount *mnt, str ...@@ -469,6 +468,7 @@ static struct nfs_open_context *alloc_nfs_open_context(struct vfsmount *mnt, str
ctx->lockowner = current->files; ctx->lockowner = current->files;
ctx->error = 0; ctx->error = 0;
ctx->dir_cookie = 0; ctx->dir_cookie = 0;
kref_init(&ctx->kref);
} }
return ctx; return ctx;
} }
...@@ -476,27 +476,33 @@ static struct nfs_open_context *alloc_nfs_open_context(struct vfsmount *mnt, str ...@@ -476,27 +476,33 @@ static struct nfs_open_context *alloc_nfs_open_context(struct vfsmount *mnt, str
struct nfs_open_context *get_nfs_open_context(struct nfs_open_context *ctx) struct nfs_open_context *get_nfs_open_context(struct nfs_open_context *ctx)
{ {
if (ctx != NULL) if (ctx != NULL)
atomic_inc(&ctx->count); kref_get(&ctx->kref);
return ctx; return ctx;
} }
void put_nfs_open_context(struct nfs_open_context *ctx) static void nfs_free_open_context(struct kref *kref)
{ {
if (atomic_dec_and_test(&ctx->count)) { struct nfs_open_context *ctx = container_of(kref,
if (!list_empty(&ctx->list)) { struct nfs_open_context, kref);
struct inode *inode = ctx->path.dentry->d_inode;
spin_lock(&inode->i_lock); if (!list_empty(&ctx->list)) {
list_del(&ctx->list); struct inode *inode = ctx->path.dentry->d_inode;
spin_unlock(&inode->i_lock); spin_lock(&inode->i_lock);
} list_del(&ctx->list);
if (ctx->state != NULL) spin_unlock(&inode->i_lock);
nfs4_close_state(&ctx->path, ctx->state, ctx->mode);
if (ctx->cred != NULL)
put_rpccred(ctx->cred);
dput(ctx->path.dentry);
mntput(ctx->path.mnt);
kfree(ctx);
} }
if (ctx->state != NULL)
nfs4_close_state(&ctx->path, ctx->state, ctx->mode);
if (ctx->cred != NULL)
put_rpccred(ctx->cred);
dput(ctx->path.dentry);
mntput(ctx->path.mnt);
kfree(ctx);
}
void put_nfs_open_context(struct nfs_open_context *ctx)
{
kref_put(&ctx->kref, nfs_free_open_context);
} }
/* /*
......
...@@ -30,6 +30,7 @@ ...@@ -30,6 +30,7 @@
#ifdef __KERNEL__ #ifdef __KERNEL__
#include <linux/in.h> #include <linux/in.h>
#include <linux/kref.h>
#include <linux/mm.h> #include <linux/mm.h>
#include <linux/namei.h> #include <linux/namei.h>
#include <linux/pagemap.h> #include <linux/pagemap.h>
...@@ -70,7 +71,7 @@ struct nfs_access_entry { ...@@ -70,7 +71,7 @@ struct nfs_access_entry {
struct nfs4_state; struct nfs4_state;
struct nfs_open_context { struct nfs_open_context {
atomic_t count; struct kref kref;
struct path path; struct path path;
struct rpc_cred *cred; struct rpc_cred *cred;
struct nfs4_state *state; struct nfs4_state *state;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment