Commit 3c1f41d5 authored by David Lechner's avatar David Lechner Committed by Jonathan Cameron

staging: iio: resolver: ad2s1210: check return of ad2s1210_initial()

This adds a check to the return value of ad2s1210_initial() since it
can fail. The call is also moved before devm_iio_device_register() so
that we don't have to unregister the device if it fails.
Signed-off-by: default avatarDavid Lechner <dlechner@baylibre.com>
Link: https://lore.kernel.org/r/20230929-ad2s1210-mainline-v3-4-fa4364281745@baylibre.comSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 9829ebac
......@@ -672,6 +672,10 @@ static int ad2s1210_probe(struct spi_device *spi)
if (ret < 0)
return ret;
ret = ad2s1210_initial(st);
if (ret < 0)
return ret;
indio_dev->info = &ad2s1210_info;
indio_dev->modes = INDIO_DIRECT_MODE;
indio_dev->channels = ad2s1210_channels;
......@@ -683,7 +687,6 @@ static int ad2s1210_probe(struct spi_device *spi)
return ret;
st->fclkin = spi->max_speed_hz;
ad2s1210_initial(st);
return 0;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment